[MRG] Fix GaussianMixture fit_predict != fit.predict when n_init > 1 #13142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Does it go into 0.20.3 or into 0.21 ? |
jnothman
approved these changes
Feb 12, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
We would ordinarily release this in 0.21, but I don't know whether we want to make 0.20.3 more extensive as an LTS and hence whether the recent patch to Stratified gold belongs there too.
agramfort
approved these changes
Feb 12, 2019
Member
|
Please add what's new |
Member
Author
|
Since the issue was in |
Member
|
Merged. Thanks @jeremiedbb! |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…nit > 1 (scikit-learn#13142)" This reverts commit cd5afb4.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…nit > 1 (scikit-learn#13142)" This reverts commit cd5afb4.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13070
Move the last
_e_stepafter having set the params to the best one found.Added a test, which fails on master.