Haversine nn #13289
Closed
Haversine nn #13289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify X = rng.rand(12, 2) delete unnecessary code lines
When I merge master, this imports was wrong on my local.
jnothman
reviewed
Feb 27, 2019
| S = pairwise_distances(X, Y, metric="haversine") | ||
| S2 = haversine_distances(X, Y) | ||
| assert_array_almost_equal(S, S2) | ||
|
|
Member
There was a problem hiding this comment.
The code below used to run on a different X
Contributor
Author
There was a problem hiding this comment.
Are you sure?
I might be wrong but I cannot find a test with a different X in the git history (the example in the docstring was changed to real places long./lat. but not this test).
Member
|
The original PR #12568 ended up being merged. Closing. Thanks for contributing @zanospi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes issue #12552
Takes over #12568
What does this implement/fix? Explain your changes.
Fix some formatting issues (lines length, hanging space & under-indentation) raised by flake8
Fix tests that were failing (haversine for sparse matrix, slicing issue in a test)
@rth @eamanu