Huber fix with bool X #13328
Merged
Huber fix with bool X #13328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dbc60e to
8838ca1
Compare
glemaitre
requested changes
Feb 28, 2019
| # Test that it does not crash with bool data | ||
| X, y = make_regression(n_samples=200, n_features=2, noise=4.0, random_state=0) | ||
| X_bool = X > 0 | ||
| huber = HuberRegressor().fit(X_bool, y) |
Member
There was a problem hiding this comment.
Suggested change
| huber = HuberRegressor().fit(X_bool, y) | |
| HuberRegressor().fit(X_bool, y) |
albertcthomas
approved these changes
Mar 1, 2019
Contributor
albertcthomas
left a comment
There was a problem hiding this comment.
LGTM but you need to rebase.
NicolasHug
reviewed
Mar 1, 2019
doc/whats_new/v0.21.rst
Outdated
|
|
||
| - |Fix| Fixed a bug in :class:`linear_model.HuberRegressor` that was | ||
| broken when X was of dtype bool. | ||
| :issue:`13314` by `Alexandre Gramfort`_. |
doc/whats_new/v0.21.rst
Outdated
| prefixed with one of the labels: |MajorFeature|, |Feature|, |Efficiency|, | ||
| |Enhancement|, |Fix| or |API|. They should be under a heading for the | ||
| relevant module (or *Multiple Modules* or *Miscellaneous*), and within each | ||
| relevant module (or *Mufltiple Modules* or *Miscellaneous*), and within each |
NicolasHug
approved these changes
Mar 1, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
* make sure huber works with boolean X * update what's new * lint * review * pep8
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit aac737f.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit aac737f.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* make sure huber works with boolean X * update what's new * lint * review * pep8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13314