be more friendly in the deprecation warning of cv=3 #13395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Mar 5, 2019
TomDLT
approved these changes
Mar 5, 2019
|
:D thanks folks! |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…#13395) * be more friendly in the deprecation of cv=3 * add hint on specifying cv * catch all the right warnings
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…it-learn#13395)" This reverts commit 2454afc.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…it-learn#13395)" This reverts commit 2454afc.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
…#13395) * be more friendly in the deprecation of cv=3 * add hint on specifying cv * catch all the right warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like that the warning tells users to not rely on the default. If we want the user not to rely on the default, we should change it to not have a default instead of 5. I think 5 is a good default and the user can happily rely on it.
I have been unhappy about this warning for a while but didn't really have the bandwidth to do something about it.
Most users will see this warning at some point, I think we should make sure it's friendly and makes sense.