Add scoring metric info in cross_val_score #13445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Mar 13, 2019
| Similar to :func:`cross_validate` | ||
| but only a single metric is permitted. | ||
|
|
||
| If None, the estimator's default scorer (if available) is used. |
There was a problem hiding this comment.
Just say "the estimator's score method"
There was a problem hiding this comment.
I'm happy with it being consistent... I'd be more happy with them all being changed :) maybe in a subsequent PR?
There was a problem hiding this comment.
@jnothman a separate PR is best as it hits files other than _validation.py as well, such as scorer.py in sklearn/metrics/ and _search.py in the same folder. I can get started on that PR if you can merge this one as it may conflict with this file.
|
Thanks! |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix #13424 by adding scoring info in
cross_val_scoreWhat does this implement/fix? Explain your changes.
Adds scoring info in
cross_val_scoredocs and referencescross_validate