fix for comparison of distcrete_features with string "auto" #13522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Mar 26, 2019
|
@MohammedKhandwawala #13497 is tackling this I suppose. |
Yes we’ve already finished the pull request, I’m just going to add some additional tests since they were missing (unrelated to the issue) |
|
Already being tackled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
To support future version of numpy avoid comparison with string.
What does this implement/fix? Explain your changes.
Checking the datatype before comparing to avoid direct comparison
Any other comments?
What should it return if invalid string is passed