Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC what's new cleaning #13706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 27, 2019
Merged

DOC what's new cleaning #13706

merged 8 commits into from
Apr 27, 2019

Conversation

jnothman
Copy link
Member

Trying to get ready for a release.

@jnothman
Copy link
Member Author

jnothman commented Apr 24, 2019

Things that might deserve listing in what's new and appear absent (from maint_tools/whats_missing.sh 0.20.3 0.21):

@jnothman jnothman added this to the 0.21 milestone Apr 25, 2019
@NicolasHug
Copy link
Member

FIX GBDT init parameter when it's a pipeline (#13472)

That one doesn't need an entry since it's only an additional fix to
#12983

@adrinjalali
Copy link
Member

ENH Convert y in GradientBoosting to float64 instead of float32 (#13524)

Maybe something like:

- |Fix| :class:`sklearn.ensemble.GradientBoostingClassifier` and
  :class:`sklearn.ensemble.GradientBoostingRegressor` now keep the
  input ``y`` as ``float64`` to avoid it being copied internally by trees.
  :pr:`13524` by `Adrin Jalali`_.

Copy link
Member Author

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review me, please :)

@jnothman
Copy link
Member Author

Thanks @NicolasHug

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a few links, LGTM :)


Something to keep in mind for later: in a few entries, we're only mentioning base classes (e.g. BaseSGDClassifier) which don't have any entry in the doc. We should mention what estimators are affected by these changes.
Same for utility functions that are sometimes public yet don't have any doc entry, such as decomposition.non_negative_factorization

@jnothman jnothman merged commit f8af325 into scikit-learn:master Apr 27, 2019
@jnothman
Copy link
Member Author

Thanks for looking over this @NicolasHug

xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
marcelobeckmann pushed a commit to marcelobeckmann/scikit-learn that referenced this pull request May 1, 2019
marcelobeckmann pushed a commit to marcelobeckmann/scikit-learn that referenced this pull request May 1, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants