[MRG] FIX Allow to disable estimator and passing weight in Voting estimators #13779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
May 4, 2019
jnothman
reviewed
May 4, 2019
doc/whats_new/v0.22.rst
Outdated
| - |Fix| :class:`sklearn.ensemble.VotingClassifier` and | ||
| :class:`sklearn.ensemble.VotingRegressor` were failing during ``fit`` in one | ||
| - |Fix| :class:`ensemble.VotingClassifier` and | ||
| :class:`ensemble.VotingRegressor` were failing during ``fit`` in one |
qinhanmin2014
approved these changes
May 5, 2019
No strong opinion. It's not a regression, but not trivial IMO. |
|
We would include it in 0.21.0 because it creates consistency with the use
of "drop" and "passthrough" in other estimators with similar syntax. (And
because it does not introduce much risk by not having been part of a
pre-release)
|
+1, ping @glemaitre |
|
OK solving the merge problem then |
|
I moved in 0.21. We also need to merge #13780 regarding the introduction of |
qinhanmin2014
approved these changes
May 6, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 6, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13777
This allows fitting with weights in Voting estimators even when one of then is set to
None.