[MRG] Adds handle unknown option to ordinal encoder #13897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Handles new values when encountered after fit. This has been referenced in issue #10465 and #11997. Although it does no passthrough NaNs or None.
What does this implement/fix? Explain your changes.
This PR uses the basic features implemented for one hot encoding to add the same functionality to OrdinalEncoder. This handles both the transform and inverse_transform. In transform category -1 is returned for new values, and None is returned in the inverse transform for -1 values.
Any other comments?
This PR might be conflicting with the work of PR #12045.
The unknown category and unknow value could be configured at intanciation.