updated class_weight explanation #14121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Jun 19, 2019
doc/glossary.rst
Outdated
| as linear SVM or logistic regression), the class weights will alter the | ||
| loss function by weighting the loss of each sample by its class weight. | ||
| For tree-based algorithms, the class weights will be used when | ||
| calculating the splitting criteria. |
Member
There was a problem hiding this comment.
reweight the splitting criterion?
amueller
approved these changes
Jun 19, 2019
Member
amueller
left a comment
There was a problem hiding this comment.
Looks good apart from nitpick. Thanks!
Member
|
If you're fixing an issue, please say "Fix # issuenumber" in your |
Contributor
Author
|
Sorry about that, I added the issue number to the PR description |
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* updated class_weight explanation * glossary_class_weight
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Jul 29, 2019
* updated class_weight explanation * glossary_class_weight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix #14111
What does this implement/fix? Explain your changes.
Added a comment about class_weight mentioning that it alters loss function for linear models, and splitting criteria for tree-based models
Any other comments?