[MRG] improving plot_digits_pipe.py by adjusting parameters and making the graph more clear #14346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR, then run time of this example is <10s, so we don't need to make it faster. |
|
I'll respectfully re-open: this example was listed as "needs speed up" in the original issue #13383. A small speed-up is always useful, especially when it comes from a new sprint attendee. In addition to the proposed changes, I'd like to suggest a few more to improve the example:
@Timsaur would you be able to handle these? Feel free to ask for help. |
NicolasHug
approved these changes
Jul 14, 2019
thomasjpfan
reviewed
Jul 14, 2019
examples/compose/plot_digits_pipe.py
Outdated
| @@ -56,8 +56,8 @@ | |||
| pca.fit(X_digits) | |||
|
|
|||
| fig, (ax0, ax1) = plt.subplots(nrows=2, sharex=True, figsize=(6, 6)) | |||
| ax0.plot(pca.explained_variance_ratio_, linewidth=2) | |||
| ax0.set_ylabel('PCA explained variance') | |||
| ax0.plot(1 + np.arange(64), pca.explained_variance_ratio_, '+', linewidth=2) | |||
There was a problem hiding this comment.
Suggested change
| ax0.plot(1 + np.arange(64), pca.explained_variance_ratio_, '+', linewidth=2) | |
| ax0.plot(np.arange(1, 65), pca.explained_variance_ratio_, '+', linewidth=2) |
There was a problem hiding this comment.
np.arange(1, pca.n_components_ + 1) ?
TomDLT
approved these changes
Jul 15, 2019
|
@Timsaur could you please resolve the merge conflicts? |
|
@Timsaur don't hesitate to ask if you need help with conflict resolution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
changed hyperparameters from:
to:
Any other comments?
the outputs for the original hyperparameters:
after changes: