Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG]Documented attributes in QuadraticDiscriminantAnalysis, RadiusNeighborsClassifier and KNeighborsClassifier, #14374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jul 24, 2019
Merged

[MRG]Documented attributes in QuadraticDiscriminantAnalysis, RadiusNeighborsClassifier and KNeighborsClassifier, #14374

merged 30 commits into from
Jul 24, 2019

Conversation

abhishek-jana
Copy link
Contributor

@abhishek-jana abhishek-jana commented Jul 15, 2019 •
edited
Loading

Partially address #14312

Covering QuadraticDiscriminantAnalysis, [classes_, covariance_] inside
sklearn/discriminant_analysis.py

added RadiusNeighborsClassifier, [classes_, effective_metric_, effective_metric_params_, outputs_2d_]
KNeighborsClassifier, [classes_, effective_metric_, effective_metric_params_, outputs_2d_]

@abhishek-jana abhishek-jana changed the title Document classes_ in QuadraticDiscriminantAnalysis [MRG]Document classes_ in QuadraticDiscriminantAnalysis Jul 15, 2019
@amueller
Copy link
Member

looks good, though it actually also has the neighbors changes in it.

@abhishek-jana
Copy link
Contributor Author

Thanks. Yeah, I didn't create a separate PR for that. Do I need to do that?

@abhishek-jana abhishek-jana changed the title [MRG]Document classes_ in QuadraticDiscriminantAnalysis [MRG]Documented attributes in QuadraticDiscriminantAnalysis, RadiusNeighborsClassifier and KNeighborsClassifier, Jul 18, 2019
thomasjpfan
thomasjpfan reviewed Jul 19, 2019
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use up to 79 characters per line.

@abhishek-jana
Copy link
Contributor Author

abhishek-jana commented Jul 20, 2019 •
edited
Loading

Thanks for reviewing @thomasjpfan. Please check the changes.

thomasjpfan
thomasjpfan reviewed Jul 20, 2019
View reviewed changes
@abhishek-jana
Copy link
Contributor Author

Is that better?

thomasjpfan
thomasjpfan reviewed Jul 21, 2019
View reviewed changes
thomasjpfan
thomasjpfan reviewed Jul 21, 2019
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove whitespace to pass linter

@abhishek-jana
Copy link
Contributor Author

Thanks. I corrected it.

@abhishek-jana
Copy link
Contributor Author

@thomasjpfan please have a look. Thanks.

@thomasjpfan thomasjpfan merged commit 786eeb7 into scikit-learn:master Jul 24, 2019
@thomasjpfan
Copy link
Member

Thank you @abhishek-jana!

@abhishek-jana
Copy link
Contributor Author

Thanks. I appreciate it.

@abhishek-jana abhishek-jana deleted the my-fetch branch July 24, 2019 01:04
@judithabk6 judithabk6 mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishek-jana @amueller @thomasjpfan