API don't default get_params output to None in the future #14464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
commented
Jul 25, 2019
|
|
||
| def __init__(self, steps, memory=None, verbose=False): | ||
| self.steps = steps | ||
| self._validate_steps() |
Member
Author
There was a problem hiding this comment.
This was calling get_params before all attributes were set.
jnothman
commented
Jul 25, 2019
| pass | ||
|
|
||
| def fit(self, X, y=None): | ||
| return self |
Member
Author
There was a problem hiding this comment.
Coverage is missing on lines like this, which I think is fine.
| return X | ||
|
|
||
| def diag(self, X): | ||
| return np.ones(X.shape[0]) |
Member
Author
There was a problem hiding this comment.
Coverage is missing on lines like this, which I think is fine.
rth
approved these changes
Jul 25, 2019
Member
|
Even if affected users will see the warning maybe it's also worth adding a what's new entry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #14461
What does this implement/fix? Explain your changes.
Previously, the default implementation of
get_paramswould usegetattrto retrieve a parameter value from an estimator, but would default to retrieve None if an AttributeError would otherwise have been raised.This can lead to surprising behaviour upon
clonewhen__init__is not correctly defined, as shown in #14461.I propose that we raise an AttributeError when a param cannot be retrieved by
getattr. This PR deprecates returning None, and raises a FutureWarning.Any other comments?
TODO: add tests