Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG+1] FIX Support float min_samples and min_cluster_size in OPTICS #14496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnothman merged 7 commits into from
Jul 29, 2019
Merged

[MRG+1] FIX Support float min_samples and min_cluster_size in OPTICS #14496

jnothman merged 7 commits into from
Jul 29, 2019

Conversation

@qinhanmin2014
Copy link
Member

@qinhanmin2014 qinhanmin2014 commented Jul 28, 2019

closes #14421
ping @jnothman

@qinhanmin2014 qinhanmin2014 added this to the 0.21.3 milestone Jul 28, 2019
@qinhanmin2014
Copy link
Member Author

qinhanmin2014 commented Jul 28, 2019

ping @adrinjalali in case you have time (last blocker for 0.21.3)

@qinhanmin2014 qinhanmin2014 mentioned this pull request Jul 28, 2019
Merged
adrinjalali
adrinjalali reviewed Jul 28, 2019
View reviewed changes
adrinjalali
adrinjalali approved these changes Jul 28, 2019
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qinhanmin2014 , this is much cleaner solution. LGTM.

@adrinjalali adrinjalali changed the title FIX Support float min_samples and min_cluster_size in OPTICS [MRG+1] FIX Support float min_samples and min_cluster_size in OPTICS Jul 28, 2019
jnothman
jnothman reviewed Jul 28, 2019
View reviewed changes
doc/whats_new/v0.21.rst Outdated

- |Fix| Fixed a bug in :class:`cluster.OPTICS` where users were unable to
pass float `min_samples` and `min_cluster_size`.
:pr:`14496` by :user:`Fabian Klopfer <someusername1>`
Copy link
Member

@jnothman jnothman Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can credit yourself

@jnothman jnothman merged commit 14dd3cb into scikit-learn:master Jul 29, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Jul 29, 2019
@qinhanmin2014 @jnothman
FIX Support float min_samples and min_cluster_size in OPTICS (scikit-…
0ef3d40 
…learn#14496)
@qinhanmin2014 qinhanmin2014 deleted the optics-float branch July 29, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees

No one assigned

Labels

Blocker

Projects

None yet

Milestone

0.21.3

Development

Successfully merging this pull request may close these issues.

3 participants

@qinhanmin2014 @jnothman @adrinjalali