-
-
Notifications
You must be signed in to change notification settings - Fork 26k
FEA Turn on early stopping in histogram GBDT by default #14516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NicolasHug
merged 40 commits into
scikit-learn:master
from
johannfaouzi:early_stopping_HGBM
Feb 12, 2020
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
b1bc2de
Update docstrings and change default value
c30e4d9
Disable early stopping for some tests
a196c5e
Check that early stopping is enabled by default
b84c7e2
Fix the random state in the examples
c02faea
Move sentence at the end of the paragraph
de41ab3
Disable early stopping in test_estimators
9e83463
Disable early stopping in partial dependence tests
6f332d0
Move the new test next to the others tests regarding ES
460a307
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn…
5764fac
Update the docstrings and the init for both classes
42f3d95
Swap warm_start and early_stopping
16a83e8
Update validation_fraction documentation
1e993d2
Update docstrings with early stopping
e08dc0b
Remove n_iter_no_cjange in set_params
30c7139
Update the tests in _hist...
36e9975
Replace n_iter_no_change with early_stopping in test_partial_dependence
081ee18
Remove early_stopping in partial_dependence
72681fd
One line is enough
eda29c8
Use 10k sample threshold for auto early stopping and resolve conflicts
johannfaouzi 99c9199
Merge branch 'master' into early_stopping_HGBM
johannfaouzi 3c4cfea
Increase the maximum number of iterations to check early stopping
johannfaouzi 73f6756
Fix min number of samples for early stopping in docstrings
johannfaouzi df72eef
Update ensemble.rst with new early stopping behavior
johannfaouzi 99a830f
Update the user guide with the new default scoring
johannfaouzi f019d47
Update code after reviews
johannfaouzi 847ed81
Fix issues in tests
johannfaouzi 39a69db
Update what's new
johannfaouzi 46864d4
Merge branch 'master' into early_stopping_HGBM
johannfaouzi 5b366d9
Make raw_predictions and raw_predictions_val private attributes
johannfaouzi a308a2f
Merge branch 'early_stopping_HGBM' of https://github.com/johannfaouzi…
johannfaouzi 7f81df7
Remove private attributes for raw predictions
johannfaouzi 58c9bce
Revert changes
johannfaouzi 4e093ad
Revert changes
johannfaouzi 52ca216
Merge branch 'master' into early_stopping_HGBM
johannfaouzi 6ed0735
Add note about scorer
johannfaouzi 29a3722
Fix test_warm_start_early_stopping
johannfaouzi 8827fb5
Merge branch 'master' of github.com:scikit-learn/scikit-learn into pr…
NicolasHug 5f65675
Merge branch 'early_stopping_HGBM' of github.com:johannfaouzi/scikit-…
NicolasHug 82a3796
fixed bad merge
NicolasHug 6f2b70a
Fixed LightGBM tests: properly deactive ES since parameters have changed
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but also happy to have all of them fixed in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we should probably have the whole file fixed in another PR since all docstrings follow the old style rn