Inconsistency of the code and its annotation in plot_ols.py #14562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and explained_variance_score are mutally replaceable, they are not the same.
Member
|
I guess we should just explicitly use r2 then? That's usually more common for such simple examples |
Contributor
Author
|
Hmmm, you are right! I didn't think through that. r2_score is more suitable than the other in such a case. |
amueller
approved these changes
Aug 5, 2019
NicolasHug
approved these changes
Aug 5, 2019
Member
|
Thanks @barrycg, and good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in
examples/linear_model/plot_ols.pywas not in accordance with its annotation. Althoughr2_scoreandexplained_variance_scoreare mutually replaceable and they even have the same value in some models, they are not the same thing.