-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[MRG] Verbose flag for VotingClassifier
and VotingRegressor
#14772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Verbose flag for VotingClassifier
and VotingRegressor
#14772
Conversation
…ssor addresses issue scikit-learn#10360
as I think you realized, this is still WIP because you need a test ;) |
VotingClassifier
and VotingRegressor
VotingClassifier
and VotingRegressor
Adding a test before MRG |
VotingClassifier
and VotingRegressor
VotingClassifier
and VotingRegressor
@amueller I think this is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @hannahbrucemacdonald !
This looks good overall, I think we could use a few more tests, in particular for the VotingRegressor class
Please add an entry to the change log at doc/whats_new/v*.rst
. Like the other entries there, please reference this pull request with :pr:
and credit yourself (and other contributors if applicable) with :user:
.
Friendly ping @hannahbrucemacdonald , could you please address the comments? Thanks! |
Happy to help out @hannahbrucemacdonald
<https://github.com/hannahbrucemacdonald>, let me know!
…On Tue, Sep 3, 2019 at 12:58 PM Nicolas Hug ***@***.***> wrote:
Friendly ping @hannahbrucemacdonald
<https://github.com/hannahbrucemacdonald> , could you please address the
comments? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14772?email_source=notifications&email_token=AANHOSTL2YAM7JBLFMEJ4Y3QH2JSLA5CNFSM4IPGYJ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5Y3MQY#issuecomment-527545923>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANHOSWDZE2PBJ6YSVIQJG3QH2JSLANCNFSM4IPGYJ4A>
.
|
Hey! Sorry I can finish this up over the weekend, unless you want to do it @spbail |
I won't be able to get to it until after, so weekend sounds great! Thanks!
…On Thu, Sep 5, 2019 at 2:04 PM Hannah Bruce Macdonald < ***@***.***> wrote:
Hey!
Sorry I can finish this up over the weekend, unless you want to do it
@spbail <https://github.com/spbail>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14772?email_source=notifications&email_token=AANHOSRYSO5CRB4FIQFSYPDQIFC25A5CNFSM4IPGYJ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AFNAQ#issuecomment-528504450>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANHOSVBILFUDY6DSTLR223QIFC25ANCNFSM4IPGYJ4A>
.
|
Hi @hannahbrucemacdonald and @spbail, we're trying to get all the PR's from the sprint finished up soon, would it be possible to wrap this one up? Thanks very much! |
Sorry I'm on holiday and won't have time until October, sorry for not getting to it sooner! |
@NicolasHug can you provide more guidance on what other tests should be added? @spbail Will you be continuing work on this PR? cc: @cmarmo (This PR is from the NYC wimlds sprint, Aug 2019.) |
r'\[Voting\].*\(classifier 3 of 3\)' | ||
' Processing gnb, total=.*\n$']) | ||
def test_voting_verbose(pattern, capsys): | ||
clf1 = LogisticRegression(random_state=123) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead use:
@pytest.mark.parametrize('est', [
VotingClassifier([('lr', LogisticRegression(random_state=123)), ('rf', RandomForestClassifier(random_state=123))]),
])
and then it's easy to also test for VotingRegressor
@spbail
This PR adds a boolean verbose flag for the classes in
voting.py
. Adds function_log_message
to_BaseVoting
and uses code format as in #11364.Verbose messages looks like: