FIX switch to binary_crossentropy if a binary problem #14869
Merged
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR. If the user specifies categorical_crossentropy on a binary classif problem, I think we should either:
I'm in favor of just raising an error (because we have the 'auto' option that just works). But I'm OK with option 2 as well. The current proposal is re-implementing the 'auto' logic but with a warning so I don't think we want that. |
Member
Author
|
@ogrisel maybe you could have a look? |
Member
Author
|
ping @ogrisel or @glemaitre should be an easy one :) |
thomasjpfan
approved these changes
Sep 19, 2019
glemaitre
approved these changes
Sep 20, 2019
Member
glemaitre
left a comment
There was a problem hiding this comment.
Apart of the comment raised by @thomasjpfan LGTM
Member
|
I pushed the fix and will merge when it is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14858.
Raise a warning and switch to
binary_crossentropyif it's a binary classification problem andcategorical_crossentropyis given.