Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] DOC Better explain the source of randomness for tree based models #15264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from Jan 8, 2020
Merged

[MRG] DOC Better explain the source of randomness for tree based models #15264

merged 10 commits into from Jan 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 15, 2019

Reference Issues/PRs

#12980

What does this implement/fix? Explain your changes.

This PR improves the documentation for DecisionTreeClassifier and DecisionTreeRegressor regarding the source of randomness. The only changes were made in the docstrings of sklearn/tree/tree.py.

This improves the documentation addressing several misinterpretations I found users make regarding the random_state parameter in tree based models.

Some of the misconceptions are

Any other comments?

@ghost ghost mentioned this pull request Oct 15, 2019
Closed
adrinjalali
adrinjalali reviewed Oct 20, 2019
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dbauer9 , this should help a lot of people.

@NicolasHug NicolasHug self-requested a review October 20, 2019 21:05
@NicolasHug NicolasHug self-assigned this Oct 20, 2019
NicolasHug
NicolasHug reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dbauer9 .

Looks good mostly. I think we should link to the glossary for the random state.

@NicolasHug
Copy link
Member

There are some line too long issues @dbauer9, you should not exceed 79 characters. You can check locally with make flake8-diff .

@MDouriez MDouriez mentioned this pull request Nov 2, 2019
Merged
@glemaitre glemaitre self-requested a review January 8, 2020 14:21
@glemaitre
Copy link
Member

I solved the conflicts and I will merge when it is green.

@glemaitre glemaitre merged commit b0c5a00 into scikit-learn:master Jan 8, 2020
@glemaitre
Copy link
Member

Thanks @dbauer9

@glemaitre glemaitre removed their request for review January 8, 2020 15:14
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
@thomasjpfan
DOC improve random_state docstring in for tree-based models (scikit-l…
545a8c9 
…earn#15264)
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
DOC improve random_state docstring in for tree-based models (scikit-l…
c31e44f 
…earn#15264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NicolasHug NicolasHug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @glemaitre @adrinjalali