[BLD] CircleCI failed when a PR generates sphinx warnings #15355

cmarmo · 2019-10-24T15:32:04Z

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR makes CircleCI documentation build fail when modified files generate sphinx warnings

Any other comments?

Note that the documentation is still rendered and visible in artifacts as before, but circleci throw exit 1.
An example is visible here

jnothman · 2019-10-24T20:21:30Z

Please use keywords in the commit message to perform a full doc build here

cmarmo · 2019-10-25T09:01:13Z

@lucyleeow and @glemaitre have just found an interesting case in #15333 : see the correspondent _changed.html.
The .rst file has been edited but the example included is unmodified, the example is not built and Sphinx warns that image is not readable.
IMO, the cleanest way to solve this is to force the build of the examples present in the modified page: the [doc quick] keyword will still be there to prevent examples to be built if we think it's unnecessary.
WDYT?

jnothman · 2019-10-26T12:21:48Z

Is it easy to determine which examples are relevant to a modified page?

cmarmo · 2019-10-26T14:06:41Z

Is it easy to determine which examples are relevant to a modified page?

At a glance I will say yes, in principle grepping figure and auto_examples in modified files could be enough. Then you redefine $changed_examples.

cmarmo · 2019-11-06T21:17:13Z

@jnothman I'm not sure this is the most elegant way to do it but it works...
An example of the output is available here: I've generated a warning in doc/modules/clustering.rst containing a number of auto-example images.
Images are generated and only the syntax warning is showed (see the _changed.html file).

thomasjpfan · 2019-11-06T21:22:07Z

I think @adrinjalali would love the bash command in this PR.

…earn into cierroronwarning

cmarmo · 2019-11-08T10:40:23Z

Hello there, just to let you know that there are no sphinx warnings right now in master (wow!) :)
Time to review this one? Thanks!

adrinjalali · 2019-11-08T11:47:52Z

This looks pretty good to me.

For the grep part, to be on the safe side, I'd probably grep for class="reference internal" first, maybe, but not strong opinions there.

And to be clear, this just tries to be a bit smarter detecting new warnings. It'll still fail to detect a new warning introduced in the example if no example or documentation is touched, but the estimator raises a new warning. Is that a correct statement?

Also, not having sphinx warnings on master has been a dream of mine lol. Awesome.

cmarmo · 2019-11-08T12:10:21Z

For the grep part, to be on the safe side, I'd probably grep for class="reference internal" first, maybe, but not strong opinions there.

The problem is that I'm grepping in the rst files not in the html: I need to know which files to build before building...

And to be clear, this just tries to be a bit smarter detecting new warnings. It'll still fail to detect a new warning introduced in the example if no example or documentation is touched, but the estimator raises a new warning. Is that a correct statement?

Totally, I'm only looking for warnings raised by the sphinx build not by the example script execution.
I was planning to take a look on #10158 and #15381 after that: is that what you had in mind?

adrinjalali

Cool. Thanks @cmarmo , so happy you're taking care of these.

thomasjpfan

Thank you @cmarmo for working on this!

thomasjpfan · 2019-11-08T16:38:21Z

build_tools/circle/build_doc.sh

+        do
+            if [ $af != "build_tools/circle/build_doc.sh" ]
+            then
+                page_figure=$(grep figure $af | grep auto_example | awk -F "/" '{print $NF}' | sed 's/sphx_glr_//' | awk -F "_" '{OFS="_";$NF=""; print $0}')


I think this is missing the examples root directory.

Please see comment regarding a chained bash script.

You are right : the example directory is not taken into account.
But the example directory is irrelevant to this line of code. As said by @adrinjalali I'm looking for examples in modified .rst pages in order to build them even if they have not been modified.
It looks to me that examples in that directory are never included in the .rst pages because they are independent pages. Am I wrong?

Sorry.. I didn't understand your comment, my answer is nonsense... you mean in the script path right?
Well I tested the build process and apparently the EXAMPLES_PATTERN argument accepts regexp, so no need for the complete path...

@cmarmo ‘s code is I feel more readable

Yes, I forgot that EXAMPLES_PATTERN is a regex, so the current solution works.

If @cmarmo 's version is more readable, we should go with the current version. I would prefer slightly to only include .rst in filenames to restrict reduce the items in the loop.

thomasjpfan · 2019-11-08T16:42:23Z

build_tools/circle/build_doc.sh

@@ -58,6 +58,25 @@ get_build_type() {
        return
    fi
    changed_examples=$(echo "$filenames" | grep -E "^examples/(.*/)*plot_")
+    if [ -n "$filenames" ]
+    then
+        for af in ${filenames[@]}


For this section how do you feel about:

if [ -n "$filenames"] then examples_in_rst=$(echo "$filenames" | \ grep -E "rst$" | \ xargs grep -shE "(figure|image)::" | \ grep auto_examples | \ awk -F "../auto_examples/" '{print $NF}' | \ sed 's/images\/sphx_glr_//' | \ sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/' | \ uniq | \ sed -e 's/^/examples\//') changed_examples="${changed_examples}\n${examples_in_rst}" fi

... well that's awesome... and clearly you had a lot of fun in building it! ;)
Is that a cryptic way to ask me to put your code in this PR? :)
Thanks for the [:digit:] thing: I looked for it for an entire afternoon without luck... not the right keywords on google search clearly...

glemaitre · 2019-11-09T19:14:09Z

From a bash newbie which always wonders what is this back magic: I would appreciate a couple of comments above the commands :) @thomasjpfan maybe having a 2 liners code with comments might make it easier to understand in a couple of weeks what these things are doing for people, as me, not good with bash WDYT?

…

On Sat, 9 Nov 2019 at 20:04, Alexandre Gramfort ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In build_tools/circle/build_doc.sh <#15355 (comment)> : > @@ -58,6 +58,25 @@ get_build_type() { return fi changed_examples=$(echo "$filenames" | grep -E "^examples/(.*/)*plot_") + if [ -n "$filenames" ] + then + for af in ${filenames[@]} + do + if [ $af != "build_tools/circle/build_doc.sh" ] + then + page_figure=$(grep figure $af | grep auto_example | awk -F "/" '{print $NF}' | sed 's/sphx_glr_//' | awk -F "_" '{OFS="_";$NF=""; print $0}') @cmarmo <https://github.com/cmarmo> ‘s code is I feel more readable — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15355?email_source=notifications&email_token=ABY32PYRI5TGA3XZJHGEQS3QS4CSHA5CNFSM4JEVXEIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLAAABY#discussion_r344457543>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABY32P7AYUWMAZ36CRODD5LQS4CSHANCNFSM4JEVXEIA> .

-- Guillaume Lemaitre Scikit-learn @ Inria Foundation https://glemaitre.github.io/

thomasjpfan · 2019-11-10T00:18:29Z

build_tools/circle/build_doc.sh

+        do
+            if [ $af != "build_tools/circle/build_doc.sh" ]
+            then
+                page_figure=$(grep figure $af | grep auto_example | awk -F "/" '{print $NF}' | sed 's/sphx_glr_//' | awk -F "_" '{OFS="_";$NF=""; print $0}')


Yes, I forgot that EXAMPLES_PATTERN is a regex, so the current solution works.

If @cmarmo 's version is more readable, we should go with the current version. I would prefer slightly to only include .rst in filenames to restrict reduce the items in the loop.

thomasjpfan · 2019-11-10T00:18:59Z

build_tools/circle/build_doc.sh

+            if [ $af != "build_tools/circle/build_doc.sh" ]
+            then
+                page_figure=$(grep figure $af | grep auto_example | awk -F "/" '{print $NF}' | sed 's/sphx_glr_//' | awk -F "_" '{OFS="_";$NF=""; print $0}')
+                page_image=$(grep image $af | grep auto_example | awk -F "/" '{print $NF}' | sed 's/sphx_glr_//' | awk -F "_" '{OFS="_";$NF=""; print $0}')


Should we update change_examples as we find them in the loop?

thomasjpfan · 2019-11-10T00:53:17Z

maybe having a 2 liners code with comments might make it
easier to understand in a couple of weeks what these things are doing for
people, as me, not good with bash

@glemaitre Yes the chain can be broken down into a few logical steps:

if [ -n "$filenames" ]; then
	# get rst files
	rst_files="$(echo "$filenames" | grep -E "rst$")"

	# get lines with figure or images
    img_fig_lines="$(echo "$rst_files" | xargs grep -shE "(figure|image)::")"

	# get only auto_examples
	auto_example_files="$(echo "$img_fig_lines" | grep auto_examples | awk -F "../auto_examples/" '{print $NF}')"

	# remove "images" from path and accept replace _\d\d\d.png with .py
	image_paths="$(echo "$auto_example_files" | sed 's/images\/sphx_glr_//' | sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"

	# get unique values
	examples_in_rst="$(echo "$image_paths" | uniq)"
fi

I hope this is clearer @cmarmo. You can use some of these ideas if you wish in your solution.

glemaitre · 2019-11-10T09:16:26Z

Yes the chain can be broken down into a few logical steps:

IMO, this is nicer for maintainability if you want non-bash wizards to get what is going on and being able to modify it if needed.

ogrisel · 2019-11-12T09:06:00Z

I think it's fine to keep it as a chain as long as the meaning of each step is documented.

ogrisel · 2019-11-12T09:06:53Z

For instance I have no idea what awk -F "../auto_examples/" '{print $NF}')" is doing.

cmarmo · 2019-11-12T12:57:38Z

For instance I have no idea what awk -F "../auto_examples/" '{print $NF}')" is doing.

awk splits your string in tokens using the string "../auto_examples/" as a separator (-F option, means Field separator) then prints the last field of the string (built-in variable NF).

cmarmo · 2019-11-12T23:46:25Z

I'm back after a lot of mistakes and some more tests (see here)...
@thomasjpfan implementation is definitely more robust wrt the problem of string concatenation, when we have to deal with the general case: modified examples and modified pages containing examples. So I've kept his extended version (with some minimal changes that are nothing that personal taste I suppose). The way the $pattern string is built has changed a bit.
Sorry @adrinjalali for revolutionizing the PR after review...

adrinjalali

No worries. It's bash, there are almost infinite ways of doing almost anything lol. I was happy with that solution, and I'm happier with this solution. I'm not too picky when it comes to bash. As long as it does the job, I'm fine with it. Thanks @cmarmo

ogrisel

Thanks for the comments detailing the different steps in parsing the content of the changed rst files.

I am not very familiar with the Circle CI configuration but it seems that the status named:

ci/circleci: doc artifact — Link to 0/doc/_changed.html

does not appear in the github interface of the PR that has a failed warning check: cmarmo#5

I think the configuration should be updated to always have this link in the github UI whenever the _changed.html artifact is generated and uploaded.

Also here are few more suggestions:

build_tools/circle/build_doc.sh

ogrisel · 2019-11-14T10:34:51Z

build_tools/circle/build_doc.sh

+        auto_example_files="$(echo "$img_fig_lines" | grep auto_examples | awk -F "/" '{print $NF}')"
+
+        # remove "sphx_glr_" from path and accept replace _\d\d\d.png with .py
+        image_paths="$(echo "$auto_example_files" | sed 's/sphx_glr_//' | sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"


Those are no longer image paths but python source files for the examples that generated the images:

Suggested change

image_paths="$(echo "$auto_example_files" | sed 's/sphx_glr_//' | sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"

examples_in_changed_rst="$(echo "$auto_example_files" | sed 's/sphx_glr_//' | sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"

and then:

# Filter duplicates: examples_in_changed_rst="$(echo "$examples_in_changed_rst" | uniq)"

Fixed... I think

ogrisel · 2019-11-14T10:37:38Z

build_tools/circle/build_doc.sh

+        then
+            # pattern for examples to run is the last line of output
+            echo BUILD: detected examples/ filename modified in $git_range: $pattern
+            echo $pattern


It seems to me that $pattern is undefined at this point.

Right. Sorry, I've rewritten this part of the script. Let me know.

ogrisel · 2019-11-14T10:44:50Z

build_tools/circle/build_doc.sh

    if [[ -n "$changed_examples" ]]
    then
-        echo BUILD: detected examples/ filename modified in $git_range: $changed_examples
-        pattern=$(echo "$changed_examples" | paste -sd '|')
+        if [[ -n "$examples_in_rst" ]]
+        then
+            pattern=$(echo "$changed_examples" | paste -sd '|')"|"$examples_in_rst
+        else
+            pattern=$(echo "$changed_examples" | paste -sd '|')
+        fi
        # pattern for examples to run is the last line of output
-        echo "$pattern"
+        echo BUILD: detected examples/ filename modified in $git_range: $pattern
+        echo $pattern
        return
+    else
+        if [[ -n "$examples_in_rst" ]]
+        then
+            # pattern for examples to run is the last line of output
+            echo BUILD: detected examples/ filename modified in $git_range: $pattern
+            echo $pattern
+            return
+        fi


I think we should be able to find way to simplify this. Maybe examples_in_changed_rst could be kept as a list of separated lines (without the final | paste -sd '|'):

examples_in_changed_rst="$(echo "$image_paths" | uniq)"

and then the concatenation in the pattern could be done as follows:

pattern="" if [[ -n "$changed_examples" ]] then pattern="$(echo "$changed_examples" | paste -sd '|')" fi if [[ -n "$examples_in_changed_rst" ]] then if [[ -n "$pattern" ]] then pattern="$pattern|$(echo "$examples_in_changed_rst" | paste -sd '|')" else pattern="$(echo "$examples_in_changed_rst" | paste -sd '|')" fi fi if [[ -n "$pattern" ]] then echo BUILD: detected examples/ filename modified in $git_range: $pattern echo $pattern fi

In retrospect I am not sure that this solution is that simpler/more readable...

ogrisel · 2019-11-14T11:06:47Z

build_tools/circle/build_doc.sh

@@ -204,5 +238,12 @@ then
    echo "$warnings" | sed 's/\/home\/circleci\/project\//<li>/g'
    echo '</ul></body></html>'
    ) > 'doc/_build/html/stable/_changed.html'
+
+    if [ $check ]


I think you can do this without introducing the check variable:

if [ -n "$warnings" ] then echo "There are Sphinx Warnings in the documentation!" echo "Please check doc/_build/html/stable/_changed.html" exit 1 fi

I've tried: but I was using grep in order to do this and grep throws an exit 1 when it could find anything, so the script exited due to the set -e... I can dig deeper if it's reeeally necessary...

ogrisel · 2019-11-14T13:02:16Z

Replying to myself:

I am not very familiar with the Circle CI configuration but it seems that the status named: "ci/circleci: doc artifact — Link to 0/doc/_changed.html" does not appear in the github interface of the PR that has a failed warning check: cmarmo#5

This because there is a specific github app registered on the main scikit-learn repo to add this link: #14731

So apparently there is nothing more to do.

thomasjpfan · 2019-11-14T14:46:31Z

build_tools/circle/build_doc.sh

+        auto_example_files="$(echo "$img_fig_lines" | grep auto_examples | awk -F "/" '{print $NF}')"
+
+        # remove "sphx_glr_" from path and accept replace _\d\d\d.png with .py
+        image_paths="$(echo "$auto_example_files" | sed 's/sphx_glr_//' | sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"


Looks like the thumb images are still here, we need to add another filter for py files:

echo "$auto_example_files" | sed 's/sphx_glr_//' | sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/' | grep -sh ".py$"

Could you please explain to me what are thumb images? Thanks ! :)
(I mean, you probably mean thumbnails somewhere, but I don't know examples of that)

Sphinx gallery generates files like IMAGE_NAME_001.png and IMAGE_NAME_thumb.png where the thumbs are used for thumbnails.

I was running some of these commands and saw some appear here.

And where do _thumb.png are linked? Could they be linked anywhere in .rst files?

thomasjpfan · 2019-11-14T14:51:30Z

build_tools/circle/build_doc.sh

+        image_paths="$(echo "$auto_example_files" | sed 's/sphx_glr_//' | sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"
+
+        # get unique values
+        examples_in_rst="$(echo "$image_paths" | uniq | paste -sd '|')"


Can we updated changed examples here by:

if [[ -n "$examples_in_rst" ]] then changed_examples="$changed_examples\n$examples_in_rst" fi

The rest of the code from here can be left unchanged.

If you take the example of cmarmo#5, in my local bash, the code
changed_examples="$changed_examples\n$examples_in_rst"
outputs
+ changed_examples='examples/svm/plot_custom_kernel.py examples/svm/plot_iris_svc.py\nplot_cluster_comparison.py plot_kmeans_assumptions.py plot_kmeans_digits.py plot_mini_batch_kmeans.py plot_affinity_propagation.py plot_mean_shift.py plot_segmentation_toy.py plot_coin_segmentation.py plot_linkage_comparison.py plot_agglomerative_dendrogram.py plot_ward_structured_vs_unstructured.py plot_agglomerative_clustering.py plot_agglomerative_clustering_metrics.py plot_dbscan.py plot_optics.py plot_birch_vs_minibatchkmeans.py plot_adjusted_for_chance_measures.py plot_tree_regression.py plot_iris_dtc.py plot_tree_regression.py plot_tree_regression_multioutput.py plot_multioutput_face_completion.py'
The \n character is printed as is, it is not translated in an EOL... if this is different from your bash, this is a portability issue anyway.
I think the actual version is ok from this point of view. WDYT?

Is there anyway to add the $examples_in_rst into $changed_examples so we leave the rest of the code unchanged?

That's all my drama... :( .. could not find it.

@thomasjpfan you've got it! :)

thomasjpfan

It is a little strange that the paste statement is not:

paste -s -d '|' -

(With the -) I needed the - to work locally.

thomasjpfan · 2019-11-14T15:31:03Z

build_tools/circle/build_doc.sh

+        scripts_names="$(echo "$auto_example_files" | sed 's/sphx_glr_//' | sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"
+
+        # get unique values
+        examples_in_rst="$(echo "$scripts_names" | uniq )"


What about:

if [[ -n "$examples_in_rst" ]] then changed_examples="$changed_examples|$examples_in_rst" fi

And leave the rest unchanged. My goal is to reduce the number of if statements after this point.

Then if $changed_examples is empty your regular expression for EXAMPLES_PATTERN will begin with |: this generates an error in every checker of regexp I've tested (maybe you know why?) and always crashes my checks in cmarmo#5

I agree. Is our Makefile tolerant to extra | when either changed_examples or examples_in_rst are empty?

Would this verbose way work?

if [[ -n "$examples_in_rst" ]] then if [[ -n "$changed_examples" ]] then changed_examples="$changed_examples|$examples_in_rst" else changed_examples="$examples_in_rst" fi fi

Yes, I go for it.
Next time you write the code and I'll do the review? I feel like the entire process will be way more efficient... ;)

thomasjpfan · 2019-11-15T15:27:29Z

@cmarmo #15633 was to test an idea from @ogrisel: #15355 (comment)

I think this PR is pretty much ready to be merged!

thomasjpfan · 2019-11-15T16:48:43Z

@cmarmo My last comment is:

    if [ "$warnings" != "/home/circleci/project/ no warnings" ]
    then
        echo "Sphinx generated warnings when building the documentation related to files modified in this PR."
        echo "Please check doc/_build/html/stable/_changed.html"
        exit 1
    fi

as seen in https://github.com/scikit-learn/scikit-learn/pull/15633/files which removes the need for the check variable. WDYT?

Given how much effort you have put into this issue, I would prefer to merge this PR.

cmarmo · 2019-11-16T17:42:58Z

Given how much effort you have put into this issue, I would prefer to merge this PR.

Dear Thomas (@thomasjpfan) I would rather not.
I haven't learned a lot in this PR except from my mistakes... ;)
The final code is definitely your code and I really find it more elegant than mine.
So go for it.
I'm not asking to have my name in a scikit-learn commit: well, I think this would be awesome, but I can live without it.
I'm trying to be useful and to have some fun. I'm not useful here because the entire process is taking too much time for me and for you for a PR that is a bit subsidiary in the scikit-learn scheme, and we both have something more interesting and useful to do. And I'm no more having fun... exactly for the same reasons, and also because I feel a bit 'remotely controlled', and I honestly don't think this is the right path for a review.
You have written a really good solution and I'm happy to see your code merged as fast as possible, because I'm tired of fixing sphinx warnings (even if this increases the number of my merged PRs... ;)).
So, "All is lost, save honor!": I willl close this PR as I can move forward and do something else.
You are welcome to take the code and open a new one that, I'm sure and I hope (!), will be merged quickly. :) Thanks for reading me.

jnothman · 2019-11-17T21:03:19Z

Many things are trickier than we think at first. But maybe messy bash scripting is the wrong thing to do in this repo in any case: should we rather write this script in python and increase maintainability??

cmarmo · 2019-11-18T15:09:01Z

Many things are trickier than we think at first. But maybe messy bash scripting is the wrong thing to do in this repo in any case: should we rather write this script in python and increase maintainability??

Well as @thomasjpfan said, so many efforts have been put in the bash approach that I would rather see merged #15633 . The code is pretty clear and new sphinx warnings are already popping up in master.

cmarmo added 3 commits October 23, 2019 17:02

Make circleCI exit with error if sphinx warnings are generated.

a642e32

Merge branch 'master' into cierroronwarning

5ed1c9c

Fix unsafe exit.

96cf750

[doc build] Fix unsafe exit.

c19c4e3

cmarmo force-pushed the cierroronwarning branch from 96cf750 to c19c4e3 Compare October 24, 2019 21:12

cmarmo added 5 commits November 6, 2019 14:03

Look for example images in modified files.

4d07039

Fix for no images in modified files.

0196e9e

Merge branch 'master' into cierroronwarning

0a0cf5f

Exclude build_doc.sh

c6735d9

Merge branch 'master' into cierroronwarning

455f500

cmarmo mentioned this pull request Nov 7, 2019

DOC Fix some new sphinx warnings. #15560

Merged

cmarmo added 2 commits November 8, 2019 11:29

Merge branch 'master' into cierroronwarning

6ac8be2

Merge branch 'cierroronwarning' of https://github.com/cmarmo/scikit-l…

5c0bafc

…earn into cierroronwarning

adrinjalali approved these changes Nov 8, 2019

View reviewed changes

thomasjpfan self-assigned this Nov 8, 2019

thomasjpfan reviewed Nov 8, 2019

View reviewed changes

thomasjpfan reviewed Nov 10, 2019

View reviewed changes

cmarmo added 2 commits November 13, 2019 00:35

Merge branch 'master' into cierroronwarning

7e664e0

Generalized implementation. Fix concatenation issues.

a2f3255

adrinjalali approved these changes Nov 13, 2019

View reviewed changes

ogrisel approved these changes Nov 14, 2019

View reviewed changes

cmarmo added 2 commits November 14, 2019 15:45

Merge branch 'master' into cierroronwarning

0749882

Address comments

bc08415

thomasjpfan reviewed Nov 14, 2019

View reviewed changes

Add comments.

f91903e

thomasjpfan reviewed Nov 14, 2019

View reviewed changes

cmarmo added 2 commits November 15, 2019 11:16

Merge branch 'master' into cierroronwarning

d533bcb

Implement @thomasjpfan solution

2fef5e7

cmarmo force-pushed the cierroronwarning branch from 06b8119 to 2fef5e7 Compare November 15, 2019 10:38

thomasjpfan mentioned this pull request Nov 15, 2019

[MRG] Enables CircleCI to fail when sphinx warns #15633

Merged

cmarmo closed this Nov 15, 2019

thomasjpfan reopened this Nov 15, 2019

cmarmo closed this Nov 16, 2019

cmarmo deleted the cierroronwarning branch December 19, 2019 14:16

	image_paths="$(echo "$auto_example_files" \| sed 's/sphx_glr_//' \| sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"
	examples_in_changed_rst="$(echo "$auto_example_files" \| sed 's/sphx_glr_//' \| sed -e 's/_[[:digit:]][[:digit:]][[:digit:]].png/.py/')"

[BLD] CircleCI failed when a PR generates sphinx warnings #15355

[BLD] CircleCI failed when a PR generates sphinx warnings #15355

Conversation

cmarmo commented Oct 24, 2019

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

jnothman commented Oct 24, 2019

cmarmo commented Oct 25, 2019

jnothman commented Oct 26, 2019 via email

cmarmo commented Oct 26, 2019

cmarmo commented Nov 6, 2019 • edited Loading

thomasjpfan commented Nov 6, 2019

cmarmo commented Nov 8, 2019

adrinjalali commented Nov 8, 2019

cmarmo commented Nov 8, 2019 • edited Loading

adrinjalali left a comment

Choose a reason for hiding this comment

thomasjpfan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glemaitre commented Nov 9, 2019 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomasjpfan commented Nov 10, 2019 • edited Loading

glemaitre commented Nov 10, 2019

ogrisel commented Nov 12, 2019

ogrisel commented Nov 12, 2019

cmarmo commented Nov 12, 2019

cmarmo commented Nov 12, 2019

adrinjalali left a comment

Choose a reason for hiding this comment

ogrisel left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogrisel commented Nov 14, 2019 • edited Loading

Choose a reason for hiding this comment

cmarmo Nov 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmarmo Nov 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomasjpfan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomasjpfan commented Nov 15, 2019

thomasjpfan commented Nov 15, 2019

cmarmo commented Nov 16, 2019

jnothman commented Nov 17, 2019

cmarmo commented Nov 18, 2019

cmarmo commented Nov 6, 2019 •

edited

Loading

cmarmo commented Nov 8, 2019 •

edited

Loading

thomasjpfan commented Nov 10, 2019 •

edited

Loading

ogrisel left a comment •

edited

Loading

ogrisel commented Nov 14, 2019 •

edited

Loading

cmarmo Nov 14, 2019 •

edited

Loading

cmarmo Nov 14, 2019 •

edited

Loading