Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX a bug where ascending and descending were inverted #15393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnothman merged 10 commits into from
Nov 6, 2019
Merged

FIX a bug where ascending and descending were inverted #15393

jnothman merged 10 commits into from
Nov 6, 2019

Conversation

@venkyyuvy
Copy link
Contributor

@venkyyuvy venkyyuvy commented Oct 29, 2019

Reference Issues/PRs: Fixes #15372

What does this implement/fix? Explain your changes.

swaped the ordering logic for ascending and descending ordering option.

@jnothman
Copy link
Member

jnothman commented Oct 29, 2019

This breaks existing tests, it seems, and we would do well to have a test which ensures this behaviour

@jnothman
Copy link
Member

jnothman commented Oct 30, 2019

Please add a test which checks that the correct order is used.

@adrinjalali
Copy link
Member

adrinjalali commented Nov 4, 2019

Added a test and a whats_new entry. @venkyyuvy you'll need to do a git pull before you do any changes now :)

@adrinjalali
Copy link
Member

adrinjalali commented Nov 5, 2019

O_o the iterative imputer fails to warn on rare occasions after one iteration? This needs some investigation

@venkyyuvy
Copy link
Contributor Author

venkyyuvy commented Nov 5, 2019 •
edited
Loading

Added a test and a whats_new entry. @venkyyuvy you'll need to do a git pull before you do any changes now :)

You are amazing man! Thanks a lot.

Now I am feeling guilty to put my name for this bug fix. Can I add your name as well in the wats_new?

I have added a random seed, to see if it fixes the warning issue.

@codecov
Copy link

codecov bot commented Nov 5, 2019 •
edited
Loading

Codecov Report

Merging #15393 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15393      +/-   ##
==========================================
+ Coverage   97.16%   97.16%   +<.01%     
==========================================
  Files         391      391              
  Lines       76858    76870      +12     
  Branches     8305     8306       +1     
==========================================
+ Hits        74680    74693      +13     
  Misses       2168     2168              
+ Partials       10        9       -1
Impacted Files Coverage Δ
sklearn/impute/_iterative.py 98.51% <ø> (ø) ⬆️
sklearn/impute/tests/test_impute.py 99.66% <100%> (ø) ⬆️
sklearn/manifold/_mds.py 94.11% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ac3fd...58deffb. Read the comment docs.

jnothman
jnothman reviewed Nov 5, 2019
View reviewed changes
@jnothman jnothman changed the title Fixing the sorting order bug FIX a bug where ascending and descending were inverted Nov 6, 2019
@jnothman
Copy link
Member

jnothman commented Nov 6, 2019

Thanks @venkyyuvy

@jnothman jnothman merged commit c96e095 into scikit-learn:master Nov 6, 2019
@venkyyuvy venkyyuvy deleted the imputer_order branch November 12, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

imputation_order "ascending" and "descending" are inverted in IterativeImputer

3 participants

@venkyyuvy @jnothman @adrinjalali