[MRG] Standardize sample weights validation in BaseDecisionTree #15495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sallie Walecka <[email protected]>
TomDLT
reviewed
Nov 2, 2019
TomDLT
approved these changes
Nov 2, 2019
Co-authored-by: Sallie Walecka <[email protected]>
TomDLT
approved these changes
Nov 2, 2019
amueller
approved these changes
Nov 2, 2019
adrinjalali
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #15358 for BaseDecisionTree
What does this implement/fix? Explain your changes.
Replaces custom validation logic with standardized method
utils.validation._check_sample_weight(relatively newly introduced).Any other comments?
Two things to check:
float32andfloat64, but the class is using._tree.DOUBLEwhich we think is the sameWe think these are both ok changes.