[ MRG | doc | #15426 | KernelRidge, AgglomerativeClustering ] #15518
Conversation
|
Looks good to me formatwise pending CI What is your strategy for obtaining these versions? |
|
@eickenberg I did a git grep for "AgglomerativeClustering" and for "KernelRidge" and used the doc/whats_new/v*** as reference for version number. |
|
This overall looks good per the change logs. How do you know that version 0.16 for |
|
Changed means that the behaviour was changed, not that a new feature was added |
| @@ -661,6 +661,8 @@ class AgglomerativeClustering(ClusterMixin, BaseEstimator): | |||
|
|
|||
| Read more in the :ref:`User Guide <hierarchical_clustering>`. | |||
|
|
|||
| .. versionadded:: 0.15 | |||
There was a problem hiding this comment.
linting fails because these should be spaces instead of tabs
| @@ -36,6 +36,8 @@ class KernelRidge(MultiOutputMixin, RegressorMixin, BaseEstimator): | |||
|
|
|||
| Read more in the :ref:`User Guide <kernel_ridge>`. | |||
|
|
|||
| .. versionchanged:: 0.16 | |||
There was a problem hiding this comment.
I think it only makes sense to report the versionadded as estimator behavior change rather frequently...
There was a problem hiding this comment.
Changes in parameter semantics are worth noting... But they need detail
|
Closing based on #15426 (comment) where we concluded that we do not need to tag for versions < 0.18 |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?