[MRG] ENH add normalize parameter to confusion_matrix #15625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
NicolasHug
reviewed
Nov 14, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Looks good. I agree it makes more sense to have it in confusion_matrix rather than in the plot utility
| normalize : {'true', 'pred', 'all'}, default=None | ||
| Normalizes confusion matrix over the true (rows), predicted (columns) | ||
| conditions or all the population. If None, confusion matrix will not be |
Member
Author
There was a problem hiding this comment.
True conditions, predicted conditions. I think that it is one way to call true values and predicted values.
| normalize : {'true', 'pred', 'all'}, default=None | ||
| Normalizes confusion matrix over the true (rows), predicited (columns) | ||
| Normalizes confusion matrix over the true (rows), predicted (columns) | ||
| conditions or all the population. If None, confusion matrix will not be |
Member
Author
There was a problem hiding this comment.
I copied it from here :). Seeking a bit more, this is defined in this way on wikipedia: https://en.wikipedia.org/wiki/Confusion_matrix
qinhanmin2014
approved these changes
Nov 15, 2019
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
I'm still wondering why we need to divide the entire matrix (though I won't oppose).
Member
|
Seems that @jnothman don't like it? #14478 (comment) |
Member
|
Not against, just needed the normalisation to have options, as here
|
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 18, 2019
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 18, 2019
adrinjalali
pushed a commit
that referenced
this pull request
Nov 19, 2019
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
closes #14478
What does this implement/fix? Explain your changes.
Move the normalization
normalizefromplot_confusion_matrixtoconfusion_matrix.I added a couple of test and handle division by zeros without raising warning.
Any other comments?