Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

glemaitre
Copy link
Member

If we can, we should use the last release of sphinx-gallery because it will catch the output in notebook style.

@glemaitre glemaitre force-pushed the is/bump_numpydoc_sphinx_gallery branch from 3672644 to 33545c6 Compare November 20, 2019 16:23
@glemaitre
Copy link
Member Author

Ping @lesteve @rth

Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this.

Though in general, I think it might be nice to move to a model that I've seen work elsewhere: always pinning versions, but having a bot propose to change the requirements when a new version is released...... (I've seen dependabot and pyup-bot do this. I'm sure there are several options.) This has the benefit that we can evaluate each new dependency release quickly, but it doesn't break PRs.

@glemaitre
Copy link
Member Author

Though in general, I think it might be nice to move to a model that I've seen work elsewhere: always pinning versions, but having a bot propose to change the requirements when a new version is released...... (I've seen dependabot and pyup-bot do this. I'm sure there are several options.) This has the benefit that we can evaluate each new dependency release quickly, but it doesn't break PRs.

I'm completely agreeing and I would be inclined to have a bot for that. For instance, we pinned the version of numpydoc and sphinx-gallery because of some bugs at the time but completely forgot to revert it meaning that we are not benefiting from the latest improvement for building the documentation.

@glemaitre
Copy link
Member Author

Can we merge this PR and open an appropriate PR to automate some of the build?

@thomasjpfan
Copy link
Member

Looks like Dependabot is the way to go since it was acquired by github and can be configured directly on github: https://dependabot.com/blog/hello-github/

@glemaitre
Copy link
Member Author

But from what I understand, these bots update requirements.txt files. If this is the case, we need our "*.yml" file to use those (at least for the pip-latest or conda-latest)

@thomasjpfan
Copy link
Member

I think we can include .dependabot/config.yml with a directory key to configure the bot to look at a specific folder. In our case, we can create a requirements.txt file just for the doc in doc folder and have the bot focus on that folder.

Reference: https://dependabot.com/docs/config-file/

@jeremiedbb jeremiedbb merged commit 6b8e545 into scikit-learn:master Nov 21, 2019
@jeremiedbb
Copy link
Member

thanks @glemaitre

adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Nov 25, 2019
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants