-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
MNT bump the version of numpydoc and sphinx gallery #15681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT bump the version of numpydoc and sphinx gallery #15681
Conversation
3672644
to
33545c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this.
Though in general, I think it might be nice to move to a model that I've seen work elsewhere: always pinning versions, but having a bot propose to change the requirements when a new version is released...... (I've seen dependabot and pyup-bot do this. I'm sure there are several options.) This has the benefit that we can evaluate each new dependency release quickly, but it doesn't break PRs.
I'm completely agreeing and I would be inclined to have a bot for that. For instance, we pinned the version of numpydoc and sphinx-gallery because of some bugs at the time but completely forgot to revert it meaning that we are not benefiting from the latest improvement for building the documentation. |
Can we merge this PR and open an appropriate PR to automate some of the build? |
Looks like Dependabot is the way to go since it was acquired by github and can be configured directly on github: https://dependabot.com/blog/hello-github/ |
But from what I understand, these bots update |
I think we can include Reference: https://dependabot.com/docs/config-file/ |
thanks @glemaitre |
If we can, we should use the last release of sphinx-gallery because it will catch the output in notebook style.