[MRG] CLN Removes ccp_alpha from RandomTreesEmbedding #15708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinhanmin2014
approved these changes
Nov 24, 2019
jnothman
approved these changes
Nov 25, 2019
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 25, 2019
|
Sorry, I'm late. We need a deprecation cycle unless this goes into 0.22 right? |
|
Looks like it's included in #15715 so all good |
jnothman
pushed a commit
that referenced
this pull request
Nov 28, 2019
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #15693 (comment)
What does this implement/fix? Explain your changes.
Removes
ccp_alphafromRandomTreesEmbedding.ccp_alphawas not released yet, so we can remove it fromRandomTreesEmbeddingwithout deprecation.CC @ogrisel @glemaitre