-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG] More explicit binder requirements for 0.22 #15847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] More explicit binder requirements for 0.22 #15847
Conversation
I am actually not sure whether this PR is preferrable compared to setting explicitly the minor version in
Reminder: the binder docker image depends on the last commit in the
In this case 0.22.1 will be the version in the binder docker image until there is a new commit in the |
So the risk is that binder will offer the previous release (because that's what was available on pypi when the binder was last loaded) until the branch is updated? Another solution might change the release process such that the circle docs are only rendered once the release is on pypi... But not sure what the right way to engineer this is. And not sure it satisfies other requirements |
A question @lesteve, sorry if I'm wrong |
Sorry I forgot about this one:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge
Follow-up on #15840.
This avoids having to change the binder requirements on each minor release.