[MRG] More deprecations for 0.23 #15860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The codecov issues seem legit. |
|
Fixed codecov ping @adrinjalali @glemaitre @thomasjpfan for a review :) |
qinhanmin2014
approved these changes
Jan 11, 2020
adrinjalali
approved these changes
Jan 13, 2020
|
Thanks @NicolasHug , and sure, I'll take care of those two PRs. |
|
awesome, thanks! |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
* removed warn_on_dtype * removed parameters to check_is_fitted * all_estimators parameters * deprecated n_components attribute in AgglomerativeClustering * change default of base.score for multioutput * removed lots of useless decorators? * changed default of copy in quantil_transform * removed six.py * nmf default value of init param * raise error instead of warning in LinearDiscriminantAnalysis * removed label param in hamming_loss * updated method parameter of power_transform * pep8 * changed default value of min_impurity_split * removed assert_false and assert_true * added and fixed versionchanged directives * reset min_impurity_split default to None * fixed LDA issue * fixed some test * more docstrings updates * set min_impurity_decrease for test to pass * upate docstring example * fixed doctest * removed multiouput.score since it's now consistent with the default * deprecate least_angle parameter combination * remove support for l1 or l2 loss in svm * removed linear_assignment.py * add test
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
* removed warn_on_dtype * removed parameters to check_is_fitted * all_estimators parameters * deprecated n_components attribute in AgglomerativeClustering * change default of base.score for multioutput * removed lots of useless decorators? * changed default of copy in quantil_transform * removed six.py * nmf default value of init param * raise error instead of warning in LinearDiscriminantAnalysis * removed label param in hamming_loss * updated method parameter of power_transform * pep8 * changed default value of min_impurity_split * removed assert_false and assert_true * added and fixed versionchanged directives * reset min_impurity_split default to None * fixed LDA issue * fixed some test * more docstrings updates * set min_impurity_decrease for test to pass * upate docstring example * fixed doctest * removed multiouput.score since it's now consistent with the default * deprecate least_angle parameter combination * remove support for l1 or l2 loss in svm * removed linear_assignment.py * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #15804 (need to be merged first)
This PR:
According to
git grep 0.23 -- sklearn/ ':!*.csv', what is left is:external.joblibfetch_...functions. #14197@adrinjalali , would you mind taking care of these, since you made the original PRs? they're a bit cryptic to me