Correct docstring definition for log_loss function #16037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NicolasHug let me know if this looks merge-able! |
jnothman
reviewed
Jan 8, 2020
sklearn/metrics/_classification.py
Outdated
| @@ -2088,8 +2088,8 @@ def log_loss(y_true, y_pred, eps=1e-15, normalize=True, sample_weight=None, | |||
|
|
|||
| This is the loss function used in (multinomial) logistic regression | |||
| and extensions of it such as neural networks, defined as the negative | |||
| log-likelihood of the true labels given a probabilistic classifier's | |||
| predictions. The log loss is only defined for two or more labels. | |||
| log-likelihood of the classfier given the true labels. | |||
There was a problem hiding this comment.
I don't think this is helpful as a definition. I suppose we mean that log_loss(y_true, y_pred) is defined as the likelihood of a logistic model that returns y_pred probabilities for its training data y_true.
There was a problem hiding this comment.
Incorporated in the pr.
|
I'm happy with @jnothman 's proposal |
|
Thanks @sid21g , as you can see the CI isn't happy because you have some line-too-long issues. Please make sure everything fits under 79 characters. Otherwise looks good! |
NicolasHug
approved these changes
Jan 13, 2020
Co-Authored-By: Nicolas Hug <[email protected]>
|
let us know @jnothman if we can close this |
|
Thanks @sid21g |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16026
What does this implement/fix? Explain your changes.
Corrects erroneous docstring under log_loss function.