Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Docstring improvements to confusion_matrix and splitters #16072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 11, 2020
Merged

DOC Docstring improvements to confusion_matrix and splitters #16072

merged 8 commits into from
Jan 11, 2020

Conversation

keyianpai
Copy link
Contributor

@keyianpai keyianpai commented Jan 9, 2020 •
edited
Loading

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Fixes #16043

add explanation :

A confusion matrix whose i-th row and j-th column entry corresponds to the number of samples with true labels in i-th class and the prediced labels in j-th class.

The afterwards commitment Fixes #16096

@glemaitre glemaitre mentioned this pull request Jan 9, 2020
Closed
@thomasjpfan thomasjpfan changed the title make docstring of confusion_matrix more clear DOC Make docstring of confusion_matrix more clear Jan 9, 2020
thomasjpfan
thomasjpfan approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @keyianpai !

jnothman
jnothman reviewed Jan 9, 2020
View reviewed changes
@keyianpai
Copy link
Contributor Author

It me who need to say thanks, I learned a lot from it! @thomasjpfan

@keyianpai keyianpai mentioned this pull request Jan 11, 2020
Closed
@keyianpai keyianpai changed the title DOC Make docstring of confusion_matrix more clear DOC Make docstring of confusion_matrix more clear and improve random_state docstring of model selection modue Jan 11, 2020
NicolasHug
NicolasHug approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @keyianpai

@NicolasHug NicolasHug changed the title DOC Make docstring of confusion_matrix more clear and improve random_state docstring of model selection modue DOC Docstring improvements to confusion_matrix and splitters Jan 11, 2020
@NicolasHug NicolasHug merged commit e3ee768 into scikit-learn:master Jan 11, 2020
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
@keyianpai @thomasjpfan
DOC Docstring improvements to confusion_matrix and splitters (scikit-…
2ee0552 
…learn#16072)
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
@keyianpai
DOC Docstring improvements to confusion_matrix and splitters (scikit-…
c00374b 
…learn#16072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

@NicolasHug NicolasHug NicolasHug approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better documentation for random_state in model selection module Docstring of confusion_matrix confusing
4 participants
@keyianpai @jnothman @NicolasHug @thomasjpfan