Update docs to indicate shuffle=True still maintains sample order within each split #16085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Jan 9, 2020
jnothman
approved these changes
Jan 10, 2020
|
Sorry I'm a bit late, but without context the new docstring is quite confusing to me. |
|
Ideas for a further improvement, @NicolasHug?
|
|
I have read through #16068 but I honestly don't understand what the problem is.
What does that mean? |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
… within each split (scikit-learn#16085)
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
… within each split (scikit-learn#16085)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16068
What does this implement/fix? Explain your changes.
As suggested in #16068, updated the documentation to indicate shuffle=True still maintains sample order within each split
Any other comments?