FIX Fix string formatting in the error message in CategoricalNB #16090
Conversation
There was a problem hiding this comment.
Thank you for the PR @madhuracj !
This needs a test in sklearn/tests/test_naive_bayes.py at test_categoricalnb. Something like this:
--- a/sklearn/tests/test_naive_bayes.py
+++ b/sklearn/tests/test_naive_bayes.py
@@ -667,6 +667,12 @@ def test_categoricalnb():
assert_raise_message(ValueError, error_msg, clf.predict, X)
assert_raise_message(ValueError, error_msg, clf.fit, X, y)
+ # Check error is failed for incorrect X
+ X = np.array([[1, 4, 1], [2, 5, 6]])
+ msg = "Expected input with 2 features, got 3 instead"
+ with pytest.raises(ValueError, match=msg):
+ clf.predict(X)
+
# Test alpha
X3_test = np.array([[2, 5]])
# alpha=1 increases the count of all categories by one so the final
|
Thanks @thomasjpfan, I've updated the PR. |
|
Please add an entry to the change log at |
There was a problem hiding this comment.
Thanks @madhuracj.
Not sure this needs a what's new entry @thomasjpfan? this isn't a bugfix
|
It may not be a numerical bug. I can see this as a user interface bug of "not showing the correct error message". I am okay with not having a whats new for this. |
|
@thomasjpfan Changelog entry added in ba48799 in case you want to include one. |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This is a simple fix, correcting the string formatting in the error message.
Any other comments?