MNT remove check for deprecated behavior in test.py #16109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
approved these changes
Jan 14, 2020
| @@ -1296,10 +1295,7 @@ def test_callable_analyzer_change_behavior(Estimator, analyzer, input_type): | |||
| data = ['this is text, not file or filename'] | |||
| warn_msg = 'Since v0.21, vectorizer' | |||
| with pytest.raises((FileNotFoundError, AttributeError)): | |||
| with pytest.warns(ChangedBehaviorWarning, match=warn_msg) as records: | |||
| Estimator(analyzer=analyzer, input=input_type).fit_transform(data) | |||
There was a problem hiding this comment.
Suggested change
| Estimator(analyzer=analyzer, input=input_type).fit_transform(data) | |
| Estimator(analyzer=analyzer, input=input_type).fit_transform(data) |
thomasjpfan
approved these changes
Jan 22, 2020
| @@ -1296,10 +1295,7 @@ def test_callable_analyzer_change_behavior(Estimator, analyzer, input_type): | |||
| data = ['this is text, not file or filename'] | |||
| warn_msg = 'Since v0.21, vectorizer' | |||
There was a problem hiding this comment.
warn_msg is not needed anymore
|
I pushed a fix for the last review comment, otherwise should be good. Merging, thanks! |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the irrelevant parts of #13641