Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH use utility _check_sample_weight in _BaseDiscreteNB #16263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2020
Merged

ENH use utility _check_sample_weight in _BaseDiscreteNB #16263

merged 3 commits into from
Jan 29, 2020

Conversation

Batalex
Copy link
Contributor

@Batalex Batalex commented Jan 28, 2020

Reference Issues/PRs

This is the last unchecked item in #15358.

What does this implement/fix? Explain your changes.

This PR uses the _check_sample_weight utils function for validating the sample weights array in _BaseDiscreteNB.

Any other comments?

rth
rth approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Batalex !

As a side comment to reviewers, we need to evaluate whether the parent issue should now be closed.

jeremiedbb
jeremiedbb approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Batalex. Just a small comment.

@jeremiedbb
Copy link
Member

jeremiedbb commented Jan 29, 2020 •
edited
Loading

As a side comment to reviewers, we need to evaluate whether the parent issue should now be closed.

@rth There's another one unmerged: #16203.

@glemaitre glemaitre changed the title [MRG] use utility _check_sample_weight in _BaseDiscreteNB ENH use utility _check_sample_weight in _BaseDiscreteNB Jan 29, 2020
glemaitre
glemaitre approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI to be green

@glemaitre glemaitre merged commit 84628b0 into scikit-learn:master Jan 29, 2020
@glemaitre
Copy link
Member

@Batalex Thanks for the PR.

@Batalex Batalex deleted the refact/check-bdiscretenb branch January 29, 2020 12:53
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
@Batalex @thomasjpfan
ENH use utility _check_sample_weight in _BaseDiscreteNB (scikit-learn…
fd8e738 
…#16263)
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
@Batalex
ENH use utility _check_sample_weight in _BaseDiscreteNB (scikit-learn…
382a20e 
…#16263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@glemaitre glemaitre glemaitre approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Batalex @jeremiedbb @glemaitre @rth