WIP Get column transform to accept other than strings #16303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
reviewed
Feb 3, 2020
|
Hi @alonsosilvaallende , Are you still interested in working on this PR? Thanks. |
|
I take over this PR. |
|
Thanks @albertvillanova: do you mind commenting "take" when you take over a PR? That way the bot will automatically unlabel the issue or the pull request. Thanks! |
|
Thanks @cmarmo. Sure, I take note of it. |
|
Take |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
WIP It tries to answer #16093
ColumnTransformer assumes elements of get_feature_names() will be strings
What does this implement/fix? Explain your changes.
It removes the assumption that the elements returned by get_feature_names() will be strings
Any other comments?
I tried to create a test with an error using both ColumnTransformer as well as DictVectorizer unsuccessfully