ENH use utility _check_sample_weight in IsotonicRegression #16322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Jan 30, 2020
ogrisel
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
LGTM. @NicolasHug are you fine with merging without your suggestion?
|
yes |
|
I saw #16322 (comment) just after my comment above. As you wish. +0 for the None weight fast path option. |
let's ignore that for this PR |
|
Merged then! Thank you very much @Batalex. |
It's not applicable here anyway because the fast way isn't implemented for IsotonicRegeression |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Continuation of #16203 so that we can close #15358.
What does this implement/fix? Explain your changes.
This PR's addition is to reorder the sample_weights array as discussed in the original PR.
I force the array to be contiguous otherwise a test would fail locally for this very reason.
Any other comments?
2020 Paris Sprint