BUG ensure that estimator_name is properly stored in the ROC display #16500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Feb 20, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
LGTM
This makes me wonder if we should remember n_cols in plot_partial_dependence, like how we remember the name here.
thomasjpfan
approved these changes
Feb 21, 2020
NicolasHug
approved these changes
Feb 23, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM otherwise, thanks @glemaitre
Member
|
feel free to self merge when CI is green |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Feb 28, 2020
ogrisel
added a commit
that referenced
this pull request
Feb 28, 2020
* FIX ensure object array are properly casted when dtype=object (#16076) * DOC Docstring example of classifier should import classifier (#16430) * MNT Update nightly build URL and release staging config (#16435) * BUG ensure that estimator_name is properly stored in the ROC display (#16500) * BUG ensure that name is properly stored in the precision/recall display (#16505) * ENH Perform KNN imputation without O(n^2) memory cost (#16397) * bump scikit-learn version for binder * bump version to 0.22.2 * MNT Skips failing SpectralCoclustering doctest (#16232) * TST Updates test for deprecation in pandas.SparseArray (#16040) * move 0.22.2 what's new entries (#16586) * add 0.22.2 in the news of the web site frontpage * skip test_ard_accuracy_on_easy_problem Co-authored-by: alexshacked <[email protected]> Co-authored-by: Oleksandr Pavlyk <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Joel Nothman <[email protected]> Co-authored-by: Thomas J Fan <[email protected]>
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were storing
estimator.__class__.__name__instead ofnamewhich wrongly label the curve when callingdisp.plot()for the second time.