Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] MNT refactoring of sgd utilities #16528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 3, 2020
Merged

[MRG] MNT refactoring of sgd utilities #16528

merged 5 commits into from
Mar 3, 2020

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Feb 23, 2020 •
edited
Loading

Removed plain_sgd and average_sgd which are just shallow wrappers around _plain_sgd.

@NicolasHug NicolasHug changed the title [WIP] MNT refactoring of sgd utilities [MRG MNT refactoring of sgd utilities Feb 23, 2020
@rth rth self-requested a review March 3, 2020 08:44
@rth rth changed the title [MRG MNT refactoring of sgd utilities [MRG] MNT refactoring of sgd utilities Mar 3, 2020
rth
rth approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, aside for minor doc comments, but it's hard to be sure nothing is missed in such refactoring.

thomasjpfan
thomasjpfan approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasHug NicolasHug merged commit 0f0f29a into scikit-learn:master Mar 3, 2020
@NicolasHug
Copy link
Member Author

Thanks for the reviews

gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@NicolasHug @gio8tisu
MNT refactoring of sgd utilities (scikit-learn#16528)
ba00ddc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @rth @thomasjpfan