Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix plot_iterative_imputer_variants_comparison.py on 0.22.X #16639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fix plot_iterative_imputer_variants_comparison.py on 0.22.X #16639

merged 1 commit into from
Mar 4, 2020

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Mar 4, 2020

Backport fix from #16302 to get examples/impute/plot_iterative_imputer_variants_comparison.py to work on the 0.22.X branch.

@ogrisel ogrisel requested a review from jeremiedbb March 4, 2020 16:25
@thomasjpfan
Copy link
Member

We most likely need to enable the CI for python 3.5 to run on PRs to the 0.22.X branch.

@ogrisel
Copy link
Member Author

ogrisel commented Mar 4, 2020

We most likely need to enable the CI for python 3.5 to run on PRs to the 0.22.X branch.

More generally it would be great to have some configuration file somewhere in each branch that states the oldest supported versions Python / numpy / scipy / cython and use that to ensure that the pyproject.toml is up to date, the readme is up to date and both the PR and the release CI are building against those oldest supported versions. The PR CI can also build on more recent things though but the release CI should only build against this.

Anyway for this PR, I think we are fine, this is just fixing an example to build the doc for 0.22.X /stable.

jeremiedbb
jeremiedbb approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeremiedbb jeremiedbb merged commit 95d4f08 into scikit-learn:0.22.X Mar 4, 2020
@jeremiedbb
Copy link
Member

We most likely need to enable the CI for python 3.5 to run on PRs to the 0.22.X branch.

it does

@ogrisel ogrisel deleted the fix-doc-0.22.X branch March 4, 2020 17:13
@thomasjpfan
Copy link
Member

Ah I see. I misunderstood how circleci works with the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogrisel @thomasjpfan @jeremiedbb @glemaitre