Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Global TOC on the sidebar everywhere #17033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Fixes #16951
Related to #16964

What does this implement/fix? Explain your changes.

Makes the global TOC on the sidebar everywhere.

@NicolasHug
Copy link
Member

The problem with this one is that it hides the structure of long UG pages like https://100626-843222-gh.circle-artifacts.com/0/doc/modules/ensemble.html

@thomasjpfan
Copy link
Member Author

Nesting TOCs is an interesting beast...

@amueller
Copy link
Member

amueller commented May 11, 2020

are we gonna do the two side menu thing or not? I kinda like it. It's working well for keras and pandas I think.

@NicolasHug
Copy link
Member

I would like it too

@thomasjpfan
Copy link
Member Author

thomasjpfan commented May 12, 2020

Closing this to prefer #17033

We will need to redo how we do the global toctree to get the double sidebar to work nicely. Sometimes our localtoc is very sparse with only one element.

Essentially for pandas and keras, they have the "global" TOC on the left, and a local toc on the right. (pandas has "global" is a slightly more local since it depends on the navbar selection)

Is the two sided menu release critical? I can most likely get something working by WednesdayFriday? if it is release critical.

Edit: Just started to think about the UX, updated to Friday as an estimate.

@NicolasHug
Copy link
Member

Is the two sided menu release critical?

I would say no, since the current docs aren't bad either, and I feel like we'd want some time to proof the new layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent navigation on user guide
3 participants