MNT Deprecate X_idx_sorted in tree module #17614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Jun 17, 2020
Member
glemaitre
left a comment
There was a problem hiding this comment.
It looks good. Could you add an entry in what's new?
Member
Author
|
Thanks @glemaitre for the review! I have already committed the suggested changes. |
thomasjpfan
reviewed
Jun 17, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @alfaro96 !
Member
Author
Thank you for the review @thomasjpfan! |
dsandeep0138
pushed a commit
to dsandeep0138/scikit-learn
that referenced
this pull request
Jun 21, 2020
rubywerman
pushed a commit
to MLH-Fellowship/scikit-learn
that referenced
this pull request
Jun 24, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #16818.
Related with #14907.
What does this implement/fix? Explain your changes.
With the deprecation of the
presorthyper-parameter, the use of theX_idx_sortedin thefitmethod has no longer effect.This PR
X_idx_sortedfrom theensembleandtreemodule and deprecates from public API.