MNT Refactor center initialization in KMeans #17928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Jul 16, 2020
sklearn/cluster/_kmeans.py
Outdated
| Squared euclidean norm of each data point. Pass it if you have it | ||
| at hands already to avoid it being recomputed here. | ||
| init : {'k-means++', 'random', ndarray, callable} |
There was a problem hiding this comment.
Suggested change
| init : {'k-means++', 'random', ndarray, callable} | |
| init : {'k-means++', 'random'}, callable or ndarray of shape (n_clusters, n_features) |
glemaitre
approved these changes
Jul 16, 2020
sklearn/cluster/_kmeans.py
Outdated
| Returns | ||
| ------- | ||
| centers : ndarray of shape(n_clusters, n_features) |
There was a problem hiding this comment.
Suggested change
| centers : ndarray of shape(n_clusters, n_features) | |
| centers : ndarray of shape (n_clusters, n_features) |
|
|
||
| n_threads = _openmp_effective_n_threads(n_threads) | ||
|
|
||
| sample_weight = _check_sample_weight(sample_weight, X, dtype=X.dtype) |
There was a problem hiding this comment.
This has been done in the main method (fit, predict, etc.)
There was a problem hiding this comment.
Right. The goal is to do all validations in the fit, predict, etc methods and have all private helpers assume validation is already done, to avoid duplicating validation
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
* refactor center init in KMeans * address comments
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the center initialization in a single place, i.e in
fit.Avoid repeated validations.
Make
_init_centroidsa method KMeans to make cleaner use of KMeans attributes.Extracted from #17622 to facilitate the reviews.
ping @glemaitre