Thanks to visit codestin.com
Credit goes to github.com

Skip to content

REL backport fixes for 0.23.2 #18068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Aug 4, 2020
Merged

REL backport fixes for 0.23.2 #18068

merged 40 commits into from
Aug 4, 2020

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Aug 3, 2020 •
edited by ogrisel
Loading

Closes #17920.

@glemaitre glemaitre marked this pull request as draft August 3, 2020 07:44
jeremiedbb and others added 3 commits August 3, 2020 09:58
@jeremiedbb @glemaitre
FIX Do not normalize sample weights in KMeans (scikit-learn#17848)
9c3b7f2 
`sample_weight` should not be normalized in KMeans. The weight magnitude
should have an influence on the `inertia_`, larger the weights, larger should be
the inertia.
@glemaitre
TST fixing kmeans
5e97918
@glemaitre
PEP8
92648d2
@ogrisel ogrisel added this to the 0.23.2 milestone Aug 3, 2020
glemaitre and others added 12 commits August 3, 2020 10:39
@glemaitre
Revert wrong merge conflicts
534d723
@ForrestCKoch @jeremiedbb
@cmarmo @thomasjpfan @glemaitre
FIX Sets dtype for pairwise_distances when metric='seuclidean' (sciki…
ef640a0 
…t-learn#15730)

Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Chiara Marmo <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
@swierh @glemaitre
ENH Fix averaged RMSE (scikit-learn#17309)
8d2af73
@cmarmo @glemaitre
[MRG+1] Make partial_fit ignore n_iter in MiniBatchDictionaryLearning (…
2761cf0 
…scikit-learn#17433)

* Make partial_fit ignore n_iter.

* Revert whiteline.

* Fix self.iter_offset.

* Add test on iter_offset_

* Add what's new entry

* Apply thomasjpfan suggestions.
@glemaitre @ogrisel
FIX fix multinomial deviance by taking the weighted average instead o…
e638793 
…f the sum (scikit-learn#17694)

Co-authored-by: Markus Rempfler <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
@jeremiedbb @glemaitre
FIX MeanShift when estimated bandwidth is 0 (scikit-learn#17742)
3a0af83
@brcharron @glemaitre
FIX Fix handling of binary_only tag in check_estimator (scikit-learn#…
f6c77e9 
…17812)

Co-authored-by: Bruno Charron <[email protected]>
@amy12xx @allanbutler
@rth @glemaitre
TST Added test for Incremental pca value error fix (scikit-learn#17985)
945af29 
Co-authored-by: Allan <[email protected]>
Co-authored-by: Roman Yurchak <[email protected]>
@amy12xx @glemaitre
FIX AffinityPropagation fix results with float32 input (scikit-learn#…
07faae3 
…17995)
@jeremiedbb @glemaitre
MNT Centralize all param checks in KMeans (scikit-learn#17861)
555157e
@glemaitre
merge conflicts
3f05fff
@jeremiedbb @glemaitre
TST Fix test_float_precision fails on arm (scikit-learn#17802)
008a51c
@glemaitre glemaitre mentioned this pull request Aug 3, 2020
Merged
glemaitre and others added 12 commits August 3, 2020 13:20
@ogrisel
Copy link
Member

ogrisel commented Aug 3, 2020

The wheel building infra is happy with this branch: MacPython/scikit-learn-wheels#63

ogrisel
ogrisel approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a manual pass to check that the list of commits in this PR is consistent with the changelog in the circle ci doc artifact.

@ogrisel ogrisel marked this pull request as ready for review August 4, 2020 09:08
@ogrisel ogrisel merged commit 947f542 into scikit-learn:0.23.X Aug 4, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@glemaitre @thomasjpfan
@jeremiedbb @lucyleeow @justmarkham @alfaro96 @ForrestCKoch @cmarmo @swierh @ogrisel @brcharron @amy12xx @allanbutler @rth @hs-nazuna @lesteve @jnothman @acharles7 @jayzed82
REL backport fixes for 0.23.2 (scikit-learn#18068)
c2caa6d 
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Lucy Liu <[email protected]>
Co-authored-by: Kevin Markham <[email protected]>
Co-authored-by: Juan Carlos Alfaro Jiménez <[email protected]>
Co-authored-by: Forrest Koch <[email protected]>
Co-authored-by: Chiara Marmo <[email protected]>
Co-authored-by: Swier <[email protected]>
Co-authored-by: t-kusanagi2 <[email protected]>
Co-authored-by: Markus Rempfler <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Bruno Charron <[email protected]>
Co-authored-by: Bruno Charron <[email protected]>
Co-authored-by: amy12xx <[email protected]>
Co-authored-by: Allan <[email protected]>
Co-authored-by: Roman Yurchak <[email protected]>
Co-authored-by: Hirofumi Suzuki <[email protected]>
Co-authored-by: Loïc Estève <[email protected]>
Co-authored-by: Joel Nothman <[email protected]>
Co-authored-by: Charles Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:cluster module:datasets module:decomposition
Projects
None yet
Milestone
0.23.2
Development

Successfully merging this pull request may close these issues.