Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC don't suggest contributors to add type annotations #18718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2020
Merged

DOC don't suggest contributors to add type annotations #18718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions doc/developers/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,11 +448,7 @@ You can check for common programming errors with the following tools:

see also :ref:`testing_coverage`

* A moderate use of type annotations is encouraged but is not mandatory. See
`mypy quickstart <https://mypy.readthedocs.io/en/latest/getting_started.html>`_
for an introduction, as well as `pandas contributing documentation
<https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#type-hints>`_
for style guidelines. Whether you add type annotation or not::
* Run static analysis with `mypy`::

mypy sklearn

Expand Down