MNT set OMP_NUM_THREADS=2 for cibuildwheel [cd build] #18807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this also impacts the pytest env but I am not that sure.
|
https://github.com/scikit-learn/scikit-learn/actions/runs/359826369 has shown that the env is passed correctly to the pytest step. I removed the debug info. This does not improve speed (maybe a bit due to skipped downloads) because the github workers only have 2 cores at the VM level instead of the docker level but this is better to set those env variables explicitly to be future proof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's check if it's possible to set the usual CI env variables to avoid network connections and oversubscription during the tests run by cibuildwheel.