Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 13, 2020

I find it really annoying to have to scroll up several pages in the CI logs to find the interesting pytest error messages. The coverage reports are better consolidated by codecov anyways. So let's disable the text report which is tedious to parse anyway.

Related to #18833.

@thomasjpfan
Copy link
Member

For both issues, do we want to use --no-summary to not show the summary? (This is a pytest 6.0 feature)

@ogrisel
Copy link
Member Author

ogrisel commented Nov 14, 2020

The XFAIL summary is probably useless.

The SKIPPED summary is probably useful to look at from time to time to check whether some tests are not always skipped on the CI for the wrong reason.

But it would actually be better to consolidate the list of skipped tests and check that a given test is not skipped on all the CI workers as we do in threadpoolctl: https://github.com/joblib/threadpoolctl/blob/master/continuous_integration/check_no_test_skipped.py

@thomasjpfan
Copy link
Member

Let's go with the original solution. Newer version of pytest + python 3.6 have had weird issues.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 14, 2020

Let's go with the original solution. Newer version of pytest + python 3.6 have had weird issues.

I was wondering if they were fixed. I will revert.

@ogrisel ogrisel force-pushed the disable-test-coverage-report-in-ci branch from 529daca to f1cd72f Compare November 14, 2020 16:02
@ogrisel
Copy link
Member Author

ogrisel commented Nov 14, 2020

Forced pushed the removal of the last 2 commits that tried to use --no-summary.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogrisel ogrisel merged commit ffcb869 into scikit-learn:master Nov 14, 2020
@ogrisel ogrisel deleted the disable-test-coverage-report-in-ci branch November 14, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants