ENH Allow path-like objects in load_svmlight_file. #19075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add also a test for this functionality.
Add what's new line for the PR.
thomasjpfan
reviewed
Aug 22, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR! I am okay with adding path-like support.
doc/whats_new/v1.2.rst
Outdated
| Cython implementation, providing 2-4x speedups. | ||
| :pr:`23127` by :user:`Meekail Zain <micky774>` | ||
|
|
||
| - |Enhancement| Path-like objects, such as those created with pathlib are now allowed as paths in :func:`datasets.load_svmlight_file` and :func:`datasets.load_svmlight_files`. |
Member
There was a problem hiding this comment.
May this be wrapped to be less than 88 characters per line to match the rest of the file?
Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
approved these changes
Aug 22, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
I left some minor docstring related comments, otherwise LGTM!
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
Co-authored-by: Thomas J. Fan <[email protected]>
andportnoy
pushed a commit
to andportnoy/scikit-learn
that referenced
this pull request
Nov 5, 2022
Co-authored-by: Thomas J. Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path-like objects, such as those created with pathlib are now allowed as paths in the
load_svmlight_fileandload_svmlight_filesfunctions.Add also a test for this functionality.