DOC Updates css consistent admonition styling #19249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Jan 23, 2021
|
+1 for color highlights in deprecated, however I'm not sure sure about versionadded,
Here the versionchanged becomes the most highlighted part of this method while it shouldn't matter for most users assuming they have a recent enough version of scikit-learn. As times goes by most versionchanged will be for fairly old versions. So in that sense putting colors there can be distracting from actually relevant information in the API docs. IMO just italics was fine, and an appropriate level of highlighting. |
|
Hm that make sense, I removed the versionadded coloring so this PR is just a minor refactor. This PR now makes the admonitions more consistent style-wise. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives more style to
versionadded:Also some refactoring so all of these admonitions have the same rounded look.