Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH Checks n_features_in_ in discriminant_analysis #19342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2021
Merged

ENH Checks n_features_in_ in discriminant_analysis #19342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e01314b
ENH Checks n_features_in_ in discriminant_analysis
thomasjpfan Feb 3, 2021
f8b987f
ENH Remove dtype casting
thomasjpfan Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sklearn/discriminant_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
from .linear_model._base import LinearClassifierMixin
from .covariance import ledoit_wolf, empirical_covariance, shrunk_covariance
from .utils.multiclass import unique_labels
from .utils import check_array
from .utils.validation import check_is_fitted
from .utils.multiclass import check_classification_targets
from .utils.extmath import softmax
Expand Down Expand Up @@ -586,7 +585,7 @@ def transform(self, X):
"solver (use 'svd' or 'eigen').")
check_is_fitted(self)

X = check_array(X)
X = self._validate_data(X, reset=False)
if self.solver == 'svd':
X_new = np.dot(X - self.xbar_, self.scalings_)
elif self.solver == 'eigen':
Expand Down Expand Up @@ -824,7 +823,7 @@ def _decision_function(self, X):
# return log posterior, see eq (4.12) p. 110 of the ESL.
check_is_fitted(self)

X = check_array(X)
X = self._validate_data(X, reset=False)
norm2 = []
for i in range(len(self.classes_)):
R = self.rotations_[i]
Expand Down
1 change: 0 additions & 1 deletion sklearn/tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ def test_search_cv(estimator, check, request):
'calibration',
'compose',
'covariance',
'discriminant_analysis',
'ensemble',
'feature_extraction',
'feature_selection',
Expand Down