Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mohaseeb
Copy link
Contributor

@mohaseeb mohaseeb commented Feb 6, 2021

Reference Issues/PRs

References #14216

What does this implement/fix? Explain your changes.

Removes the use of assert_raises* in model_selection/tests/test_search.py

Any other comments?

cc: (pair programming partner) @cycks

@reshamas
Copy link
Member

reshamas commented Feb 6, 2021

#DataUmbrella sprint

@glemaitre glemaitre changed the title MAINT Remove the use of assert_raises* in model_selection/tests/test_search MAINT replace assert_raises* by pytest.raise in model_selection/tests/test_search Feb 6, 2021
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Let see if the CIs will not catch anything that I would have miss.

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when CI shows green light.

@lorentzenchr lorentzenchr merged commit a952fbb into scikit-learn:main Feb 6, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants